diff options
| author | Luke T. Shumaker <lukeshu@lukeshu.com> | 2025-03-18 10:53:12 -0600 |
|---|---|---|
| committer | Luke T. Shumaker <lukeshu@lukeshu.com> | 2025-03-26 22:06:14 -0600 |
| commit | 865bb702f828784a0225b5eae9ed8803094140d5 (patch) | |
| tree | b579303cc5df38191ee9e8ad63793fbe4c867c02 /lib9p/include | |
| parent | 63fcccd84cb348b1b4194024a0dea4dd81941daf (diff) | |
lib9p: Adjust for reads to be zero-copy
Diffstat (limited to 'lib9p/include')
| -rw-r--r-- | lib9p/include/lib9p/srv.h | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/lib9p/include/lib9p/srv.h b/lib9p/include/lib9p/srv.h index a714125..ff5ebdc 100644 --- a/lib9p/include/lib9p/srv.h +++ b/lib9p/include/lib9p/srv.h @@ -40,6 +40,12 @@ int lib9p_srv_acknowledge_flush(struct lib9p_srv_ctx *ctx); lo_interface lib9p_srv_fio; lo_interface lib9p_srv_dio; +/* FIXME: I don't like that the pointers returned by stat() and + * pread() have to remain live after they return. Perhaps a + * `respond()`-callback? But that just reads as gross in C. + * + * FIXME: It would be nice if pread() could return more than 1 iovec. + */ #define lib9p_srv_file_LO_IFACE \ /* resource management **********************************************/ \ \ @@ -90,16 +96,23 @@ LO_INTERFACE(lib9p_srv_file); LO_FUNC(struct lib9p_qid , qid ) \ LO_FUNC(void , iofree ) \ LO_FUNC(uint32_t , iounit ) \ - LO_FUNC(uint32_t , pread , struct lib9p_srv_ctx *, \ - void *buf, \ + LO_FUNC(void , pread , struct lib9p_srv_ctx *, \ uint32_t byte_count, \ - uint64_t byte_offset) \ + uint64_t byte_offset, \ + struct iovec *ret) \ LO_FUNC(uint32_t , pwrite , struct lib9p_srv_ctx *, \ void *buf, \ uint32_t byte_count, \ uint64_t byte_offset) LO_INTERFACE(lib9p_srv_fio); +/* FIXME: The dio interface just feels clunky. I'm not in a rush to + * change it because util9p_static_dir is already implemented and I + * don't anticipate the sbc-harness needing another dio + * implementation. But if I wanted lib9p to be used outside of + * sbc-harness, this is one of the first things that I'd want to + * change. + */ #define lib9p_srv_dio_LO_IFACE \ LO_FUNC(struct lib9p_qid , qid ) \ LO_FUNC(void , iofree ) \ |