Refactor to *finally* get rid of the god-class "MessageManager".

Accomplish this largely by using singletons.

Now, I know this breaks the "build", at least in PHP 5.2. But there's
a lot here that's good stuff, so just wait for the next commit.

Now, a *LOT* changed, as you can see by the size of the diff; it's
about a day and a half of editing worth of editing. I'll describe a
little of it, but I'm not going to go into a ton of detail, and won't
bother trying to break it into separate commits (they're all so
interconnected, it would be mental masturbation). 'Cause I'm the only
one looking at it at this point.

 1. MessageManager did 3 things:
    A. Act as a global site class. This has been moved into
      `lib/Site.class.php'
    B. Act as a registry for singletons. Now there's a
       `lib/Singleton.class.php' abstract class to let them manage
       themselves.
        : Note: With the possible exception of Database, none of the :
        :       singletons *need* to be singletons, but to create    :
        :       multiple of them would be wasteful.                  :
    C. Check if the database conf file exists, and if it doesn't show
       an error message. This has been moved into index.php, and the
       message has been turned into a proper view.
 2. Recognize `Auth.class.php' for what it is, a multiton.
    Rename Auth::getObj to Auth::getInstance to be consistant with
    singletons.
 3. Make Site->baseUrl() (formerly `MessageManager->baseUrl()') figure
    the base URL each time, either with or without the database. This
    way we can be more flexible with initing the Template.
 4. Init Template (now a singleton) sanely. We can now use views with
    no DB.

I will use the above to shorten the below file changes:

index.php: [1C]
    Also, just tidy up.
src/controllers/Users.class.php: [1B] [2]
src/lib/Controller.class.php: [4]
src/lib/DB.class.php: [1B] [2]
src/lib/Database.class.php: [1B]
src/lib/Hasher.class.php: [1B] (new file)
    A singleton wrapper around `ext/PasswordHash.class.php', use
    bcrypt while exposing fewer internals.
src/lib/Login.class.php: [1B]
src/lib/MessageManager.class.php: [1]
src/lib/Model.class.php: [1B] (new file)
    A abstract class for models, so they don't have to worry about
    initing the DB.
src/lib/PluginManager.class.php: [1B]
src/lib/Singleton.class.php: [1B] (new file)
    An abstract class that will take care of being a singleton for
    you; in order to make a class a singleton, just extend Singleton.
src/lib/Site.class.php: [1A] [3] (new file)
src/lib/View.class.php: [4]
src/models/Auth.class.php: [2] [1B]
    Also make getUsername safely return false if the DB isn't
    connected.
src/models/ContactMethod: extend `Model'
src/views/Template.class.php: [1B] [3]
src/views/pages/no-conf.html.php: [1C]
src/views/pages/plugins/index.html.php: [1B]
src/views/pages/users/500.html.php: [1B]

1 files changed, 8 insertions, 8 deletions

diff --git a/src/lib/DB.class.php b/src/lib/DB.class.php
index 5954726..ac8dafe 100644
--- a/src/lib/DB.class.php
+++ b/src/lib/DB.class.php
@@ -1,7 +1,7 @@
 <?php
-
 require_once('Auth.class.php');
 require_once('Login.class.php');
+require_once('Database.class.php');
 
 class DB {
 	public static function set($table, $unit, $key, $value, $orig_value) {
@@ -65,8 +65,8 @@ class DB {
 	}
 	
 	private static function user_get($uid, $key) {
-		$user = Auth::getObj($uid);
-		$logged_in_user = Auth::getObj(Login::isLoggedIn());
+		$user = Auth::getInstance($uid);
+		$logged_in_user = Auth::getInstance(Login::isLoggedIn());
 		
 		$post_key = $key."[$uid]";
 		@$value = $_POST[$post_key];
@@ -103,7 +103,7 @@ class DB {
 		             'editable'=>$editable);
 	}
 	private static function user_set($uid, $key, $value) {
-		$user = Auth::getObj($uid);
+		$user = Auth::getInstance($uid);
 		
 		switch ($key) {
 		case 'auth_uid':
@@ -127,8 +127,8 @@ class DB {
 	}
 	
 	private static function admin_get($plugin, $key) {
-		global $mm; $db = $mm->database();
-		$user = Auth::getObj(Login::isLoggedIn());
+		$db = Database::getInstance();
+		$user = Auth::getInstance(Login::isLoggedIn());
 		if ($user->isAdmin()) {
 			$editable = true;
 			switch ($plugin) {
@@ -149,8 +149,8 @@ class DB {
 		             'editable'=>$editable);
 	}
 	private static function admin_set($plugin, $key, $value) {
-		global $mm; $db = $mm->database();
-		$user = Auth::getObj(Login::isLoggedIn());
+		$db = Database::getInstance();
+		$user = Auth::getInstance(Login::isLoggedIn());
 		if (!$user->isAdmin()) {
 			return false;
 		}