From 42729f477684b12735b572a4975d32fb1002a530 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Sat, 26 Apr 2025 23:30:31 -0600 Subject: libhw_generic: io.h: Clarify that sum lenghts of iovecs must not be 0 --- libhw_cr/w5500.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'libhw_cr/w5500.c') diff --git a/libhw_cr/w5500.c b/libhw_cr/w5500.c index e676364..cb424b0 100644 --- a/libhw_cr/w5500.c +++ b/libhw_cr/w5500.c @@ -608,10 +608,9 @@ static ssize_t w5500_tcp_writev(struct _w5500_socket *socket, const struct iovec size_t count = 0; for (int i = 0; i < iovcnt; i++) count += iov[i].iov_len; + assert(count); log_debugf("tcp_conn.write(%zu)", count); ASSERT_SELF(stream_conn, TCP); - if (count == 0) - return 0; /* What we really want is to pause until we receive an ACK for * some data we just queued, so that we can line up some new @@ -701,10 +700,9 @@ static ssize_t w5500_tcp_readv(struct _w5500_socket *socket, const struct iovec size_t count = 0; for (int i = 0; i < iovcnt; i++) count += iov[i].iov_len; + assert(count); log_debugf("tcp_conn.read(%zu)", count); ASSERT_SELF(stream_conn, TCP); - if (count == 0) - return 0; struct alarmclock_trigger trigger = {}; if (socket->read_deadline_ns) -- cgit v1.2.3-2-g168b From b4a081932338f65aa87aeba5008463feb0a78519 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Mon, 12 May 2025 14:17:05 -0600 Subject: More GCC 15 fixes --- libhw_cr/w5500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libhw_cr/w5500.c') diff --git a/libhw_cr/w5500.c b/libhw_cr/w5500.c index cb424b0..2893e8f 100644 --- a/libhw_cr/w5500.c +++ b/libhw_cr/w5500.c @@ -436,7 +436,7 @@ static void w5500_if_ifup(struct w5500 *chip, struct net_iface_config cfg) { static void w5500_if_ifdown(struct w5500 *chip) { log_debugf("if_down()"); - _w5500_if_up(chip, (struct net_iface_config){0}); + _w5500_if_up(chip, (struct net_iface_config){}); } static lo_interface net_stream_listener w5500_if_tcp_listen(struct w5500 *chip, uint16_t local_port) { -- cgit v1.2.3-2-g168b