From d2afc58a861ba9d5a1add97d42a3b5aaa0536450 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Tue, 8 Apr 2025 20:54:56 -0600 Subject: lib9p: srv: Drop the sess->rerror_overhead field --- lib9p/protogen/c.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'lib9p/protogen/c.py') diff --git a/lib9p/protogen/c.py b/lib9p/protogen/c.py index a6824ce..363f0df 100644 --- a/lib9p/protogen/c.py +++ b/lib9p/protogen/c.py @@ -122,6 +122,11 @@ def gen_c(versions: set[str], typs: list[idl.UserType]) -> str: ret += f"const struct {c9util.ident('_ver_tentry')} {c9util.ident('_table_ver')}[{c9util.ver_enum('NUM')}] = {{\n" rerror = next(typ for typ in typs if typ.typname == "Rerror") for ver in ["unknown", *sorted(versions)]: + # XXX: There are good arguments that min_msg_size should be + # something larger than rerror.min_size(). + # srv.c:respond_error() assumes that min_msg_size is + # rerror.min_size(); if you do change min_msg_size to + # something larger, then be sure to update respond_error(). if ver == "unknown": min_msg_size = rerror.min_size("9P2000") # SPECIAL (initialization) else: -- cgit v1.2.3-2-g168b