From fa8fd67d5b057ec50a424bfa6a000346e3744175 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Sat, 17 May 2025 00:11:56 -0600 Subject: Don't forget to use (void) in signatures without arguments --- cmd/sbc_harness/usb_keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd/sbc_harness/usb_keyboard.c') diff --git a/cmd/sbc_harness/usb_keyboard.c b/cmd/sbc_harness/usb_keyboard.c index 0573dba..c9f5a6e 100644 --- a/cmd/sbc_harness/usb_keyboard.c +++ b/cmd/sbc_harness/usb_keyboard.c @@ -20,7 +20,7 @@ static uint8_t const hid_report_descriptor_keyboard[] = { TUD_HID_REPORT_DESC_KE static uint8_t kbd_ifc = 0; -void usb_keyboard_init() { +void usb_keyboard_init(void) { if (kbd_ifc) return; -- cgit v1.2.3-2-g168b From ef72481ffee3403dc50e93b5686c30ed841e0257 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Sat, 17 May 2025 12:43:02 -0600 Subject: Consistently use LM_UNUSED instead of (void) casts --- cmd/sbc_harness/usb_keyboard.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'cmd/sbc_harness/usb_keyboard.c') diff --git a/cmd/sbc_harness/usb_keyboard.c b/cmd/sbc_harness/usb_keyboard.c index c9f5a6e..f0726cb 100644 --- a/cmd/sbc_harness/usb_keyboard.c +++ b/cmd/sbc_harness/usb_keyboard.c @@ -93,15 +93,12 @@ uint8_t const *tud_hid_descriptor_report_cb(uint8_t index) { return reports[index]; } -uint16_t tud_hid_get_report_cb(uint8_t instance, uint8_t report_id, hid_report_type_t report_type, uint8_t* buffer, uint16_t reqlen) -{ +uint16_t tud_hid_get_report_cb(uint8_t LM_UNUSED(instance), + uint8_t LM_UNUSED(report_id), + hid_report_type_t LM_UNUSED(report_type), + uint8_t* LM_UNUSED(buffer), + uint16_t LM_UNUSED(reqlen)) { // TODO not implemented - (void) instance; - (void) report_id; - (void) report_type; - (void) buffer; - (void) reqlen; - return 0; } -- cgit v1.2.3-2-g168b From 7cbd849648d41c8b55b5b5fe618b8d20e75db868 Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Sat, 17 May 2025 12:38:59 -0600 Subject: Sort+align #includes --- cmd/sbc_harness/usb_keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd/sbc_harness/usb_keyboard.c') diff --git a/cmd/sbc_harness/usb_keyboard.c b/cmd/sbc_harness/usb_keyboard.c index f0726cb..fc273eb 100644 --- a/cmd/sbc_harness/usb_keyboard.c +++ b/cmd/sbc_harness/usb_keyboard.c @@ -6,9 +6,9 @@ #include +#include #include /* for TUD_ENDPOINT_IN */ #include -#include #include "usb_keyboard.h" -- cgit v1.2.3-2-g168b From 3c512ac435bb054e56b06a93adf7e74e4ce352fc Mon Sep 17 00:00:00 2001 From: "Luke T. Shumaker" Date: Sat, 17 May 2025 12:47:44 -0600 Subject: Fix some funny indents --- cmd/sbc_harness/usb_keyboard.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'cmd/sbc_harness/usb_keyboard.c') diff --git a/cmd/sbc_harness/usb_keyboard.c b/cmd/sbc_harness/usb_keyboard.c index fc273eb..dcd4465 100644 --- a/cmd/sbc_harness/usb_keyboard.c +++ b/cmd/sbc_harness/usb_keyboard.c @@ -85,12 +85,12 @@ COROUTINE usb_keyboard_cr(void *_chan) { * ยง6.2.2 "Report Descriptor") for the given index. */ uint8_t const *tud_hid_descriptor_report_cb(uint8_t index) { - static uint8_t const *reports[] = { - hid_report_descriptor_keyboard, - }; - if (index >= TU_ARRAY_SIZE(reports)) - return NULL; - return reports[index]; + static uint8_t const *reports[] = { + hid_report_descriptor_keyboard, + }; + if (index >= TU_ARRAY_SIZE(reports)) + return NULL; + return reports[index]; } uint16_t tud_hid_get_report_cb(uint8_t LM_UNUSED(instance), -- cgit v1.2.3-2-g168b