From 95ceb2a4a42093c9fd728e9e3d546943bc7b0b9d Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Sat, 20 Apr 2013 11:03:00 -0500
Subject: Remove spaceless from depends and required by template fragments

This was a bit of premature optimization, and ends up slowing the page
generation a good amount since we have to run this ~400 times on some
packages with long depends or required by lists. Webserver compression
should handle this just fine and not result in too much page bloat.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/details_depend.html     | 5 ++---
 templates/packages/details_requiredby.html | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

(limited to 'templates/packages')

diff --git a/templates/packages/details_depend.html b/templates/packages/details_depend.html
index 4aa739c2..b89ffbfa 100644
--- a/templates/packages/details_depend.html
+++ b/templates/packages/details_depend.html
@@ -1,5 +1,4 @@
-{% load package_extras %}{% spaceless %}<li>
-{% ifequal depend.pkg None %}
+{% load package_extras %}<li>{% ifequal depend.pkg None %}
 {% if depend.providers %}{{ depend.dep.name }}{{ depend.dep.comparison|default:"" }}{{ depend.dep.version|default:"" }} <span class="virtual-dep">({% multi_pkg_details depend.providers %})</span>
 {% else %}{{ depend.dep.name }}{{ depend.dep.comparison|default:"" }}{{ depend.dep.version|default:"" }} <span class="virtual-dep">(virtual)</span>
 {% endif %}{% else %}
@@ -11,4 +10,4 @@
 {% endif %}{% if depend.dep.deptype == 'M' %} <span class="make-dep"> (make)</span>
 {% endif %}{% if depend.dep.deptype == 'C' %} <span class="check-dep"> (check)</span>
 {% endif %}{% if depend.dep.description %} - <span class="dep-desc">{{ depend.dep.description }}</span>
-{% endif %}</li>{% endspaceless %}
+{% endif %}</li>
diff --git a/templates/packages/details_requiredby.html b/templates/packages/details_requiredby.html
index e8c713ac..504a322f 100644
--- a/templates/packages/details_requiredby.html
+++ b/templates/packages/details_requiredby.html
@@ -1,8 +1,8 @@
-{% load package_extras %}{% spaceless %}<li>{% pkg_details_link req.pkg %}
+{% load package_extras %}<li>{% pkg_details_link req.pkg %}
 {% if req.name != pkg.pkgname %}<span class="virtual-dep"> (requires {{ req.name }})</span>
 {% endif %}{% if req.pkg.repo.testing %}<span class="testing-dep"> (testing)</span>
 {% endif %}{% if req.pkg.repo.staging %}<span class="staging-dep"> (staging)</span>
 {% endif %}{% if req.deptype == 'O' %}<span class="opt-dep"> (optional)</span>
 {% endif %}{% if req.deptype == 'M' %}<span class="make-dep"> (make)</span>
 {% endif %}{% if req.deptype == 'C' %}<span class="check-dep"> (check)</span>
-{% endif %}</li>{% endspaceless %}
+{% endif %}</li>
-- 
cgit v1.2.3-2-g168b


From b519c40e0af5b86ba660cf9d9cfc53a66fd8bef8 Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Sat, 20 Apr 2013 11:11:04 -0500
Subject: Remove {% spaceless %} tag from a few more places

This tag is simply not worth the time it takes to do what it does.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/search.html   | 6 ++----
 templates/packages/signoffs.html | 8 ++------
 2 files changed, 4 insertions(+), 10 deletions(-)

(limited to 'templates/packages')

diff --git a/templates/packages/search.html b/templates/packages/search.html
index bf1eecd9..f50bc8be 100644
--- a/templates/packages/search.html
+++ b/templates/packages/search.html
@@ -69,8 +69,7 @@
                 </tr>
             </thead>
             <tbody>
-            {% for pkg in package_list %}
-                {% spaceless %}<tr class="{% cycle 'odd' 'even' %}">
+                {% for pkg in package_list %}<tr class="{% cycle 'odd' 'even' %}">
                     {% if perms.main.change_package %}
                     <td><input type="checkbox" name="pkgid" value="{{ pkg.id }}" /></td>
                     {% endif %}
@@ -85,8 +84,7 @@
                     <td class="wrap">{{ pkg.pkgdesc }}</td>
                     <td>{{ pkg.last_update|date }}</td>
                     <td>{{ pkg.flag_date|date }}</td>
-                </tr>
-            {% endspaceless %}{% endfor %}
+                </tr>{% endfor %}
             </tbody>
         </table>
         {% include "packages/search_paginator.html" %}
diff --git a/templates/packages/signoffs.html b/templates/packages/signoffs.html
index 20371f95..2879c30b 100644
--- a/templates/packages/signoffs.html
+++ b/templates/packages/signoffs.html
@@ -50,9 +50,7 @@
             </tr>
         </thead>
         <tbody id="tbody_signoffs">
-            {% for group in signoff_groups %}
-            <tr class="{% cycle 'odd' 'even' %} {{ group.arch.name }} {{ group.target_repo|lower }}">
-                {% spaceless %}
+            {% for group in signoff_groups %}<tr class="{% cycle 'odd' 'even' %} {{ group.arch.name }} {{ group.target_repo|lower }}">
                 <td>{% pkg_details_link group.package %} {{ group.version }}</td>
                 <td>{{ group.arch.name }}</td>
                 <td>{{ group.target_repo }}</td>
@@ -75,9 +73,7 @@
                     {% endcomment %}{% if spec.known_bad %}Package is known to be bad<br/>{% endif %}{% comment %}
                     {% endcomment %}{{ spec.comments|default:""|linebreaksbr }}
                 {% endwith %}{% endif %}</td>
-                {% endspaceless %}
-            </tr>
-            {% endfor %}
+            </tr>{% endfor %}
         </tbody>
     </table>
 </div>
-- 
cgit v1.2.3-2-g168b


From 3e085183bf39c59fdcd0b9e67b5a02653a51d30e Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Sat, 20 Apr 2013 11:28:12 -0500
Subject: Move all script blocks into {% script_block %} section

I added this a while back, but didn't roll it out to all templates.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/details.html         | 2 ++
 templates/packages/differences.html     | 2 ++
 templates/packages/groups.html          | 3 +++
 templates/packages/packages_list.html   | 3 +++
 templates/packages/signoffs.html        | 3 +++
 templates/packages/stale_relations.html | 3 +++
 6 files changed, 16 insertions(+)

(limited to 'templates/packages')

diff --git a/templates/packages/details.html b/templates/packages/details.html
index 0a47217c..bfa2de16 100644
--- a/templates/packages/details.html
+++ b/templates/packages/details.html
@@ -229,7 +229,9 @@
         </div>
     </div>
 </div>
+{% endblock %}
 
+{% block script_block %}
 {% load cdn %}{% jquery %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
diff --git a/templates/packages/differences.html b/templates/packages/differences.html
index 61906fef..3d3f6edf 100644
--- a/templates/packages/differences.html
+++ b/templates/packages/differences.html
@@ -93,7 +93,9 @@
     </table>
 
 </div>
+{% endblock %}
 
+{% block script_block %}
 {% load cdn %}{% jquery %}{% jquery_tablesorter %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
diff --git a/templates/packages/groups.html b/templates/packages/groups.html
index 66110637..c135791f 100644
--- a/templates/packages/groups.html
+++ b/templates/packages/groups.html
@@ -29,6 +29,9 @@
         </tbody>
     </table>
 </div>
+{% endblock %}
+
+{% block script_block %}
 {% load cdn %}{% jquery %}{% jquery_tablesorter %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
diff --git a/templates/packages/packages_list.html b/templates/packages/packages_list.html
index 37fd2c1c..3dcc03dc 100644
--- a/templates/packages/packages_list.html
+++ b/templates/packages/packages_list.html
@@ -40,6 +40,9 @@
         </tbody>
     </table>
 </div>
+{% endblock %}
+
+{% block script_block %}
 {% load cdn %}{% jquery %}{% jquery_tablesorter %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
diff --git a/templates/packages/signoffs.html b/templates/packages/signoffs.html
index 2879c30b..6fbbd00e 100644
--- a/templates/packages/signoffs.html
+++ b/templates/packages/signoffs.html
@@ -77,6 +77,9 @@
         </tbody>
     </table>
 </div>
+{% endblock %}
+
+{% block script_block %}
 {% load cdn %}{% jquery %}{% jquery_tablesorter %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
diff --git a/templates/packages/stale_relations.html b/templates/packages/stale_relations.html
index cb7799d4..14fac397 100644
--- a/templates/packages/stale_relations.html
+++ b/templates/packages/stale_relations.html
@@ -107,6 +107,9 @@
     </form>
 
 </div>
+{% endblock %}
+
+{% block script_block %}
 {% load cdn %}{% jquery %}{% jquery_tablesorter %}
 <script type="text/javascript" src="{% static "archweb.js" %}"></script>
 <script type="text/javascript">
-- 
cgit v1.2.3-2-g168b


From 7873cb9a052c7991f3d91ddf4dc05caef6305cd7 Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Sat, 20 Apr 2013 13:31:20 -0500
Subject: Unbreak the package differences page

We had a weird conditional around everything on the page that doesn't
really need to be there. Remove it.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/differences.html | 2 --
 1 file changed, 2 deletions(-)

(limited to 'templates/packages')

diff --git a/templates/packages/differences.html b/templates/packages/differences.html
index 3d3f6edf..b0b9b419 100644
--- a/templates/packages/differences.html
+++ b/templates/packages/differences.html
@@ -5,7 +5,6 @@
 {% block navbarclass %}anb-packages{% endblock %}
 
 {% block content %}
-{% if differences %}
 <div class="box">
     <h2>Package Differences by Architecture</h2>
     <div class="filter-criteria">
@@ -111,5 +110,4 @@ $(document).ready(function() {
     filter_packages();
 });
 </script>
-{% endif %}
 {% endblock %}
-- 
cgit v1.2.3-2-g168b