From 6a429a8d898d5f0789f5b5a3f2858c6578fa5227 Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Mon, 7 Mar 2011 21:50:13 -0600
Subject: Clean up current_query and preserve multiple args

When implementing search for multiple architectures or repositories, I
didn't update this method to accomidate the new query parameters. Clean
it up a bit by not appending/stripping the leading '?' anywhere but in
the template itself, and ensure we can handle multiple of any parameter
passed in. Fixes FS#23180.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/search.html | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

(limited to 'templates/packages/search.html')

diff --git a/templates/packages/search.html b/templates/packages/search.html
index dad05ffa..5d0de1f4 100644
--- a/templates/packages/search.html
+++ b/templates/packages/search.html
@@ -50,13 +50,13 @@
 
         <p class="pkglist-nav">
             {% if page_obj.has_previous %}
-            <a class="prev" href="/packages/{{page_obj.previous_page_number}}/{{current_query}}"
+            <a class="prev" href="/packages/{{page_obj.previous_page_number}}/?{{current_query}}"
                 title="Go to previous page">&lt; Prev</a>
             {% else %}
             <span class="prev">&lt; Prev</span>
             {% endif %}
             {% if page_obj.has_next %}
-            <a class="next" href="/packages/{{page_obj.next_page_number}}/{{current_query}}"
+            <a class="next" href="/packages/{{page_obj.next_page_number}}/?{{current_query}}"
                 title="Go to next page">Next &gt;</a>
             {% else %}
             <span class="next">Next &gt;</span>
@@ -74,17 +74,17 @@
                     {% if perms.main.change_package %}
                     <th>&nbsp;</th>
                     {% endif %}
-                    <th><a href="/packages/{% buildsortqs "arch" %}"
+                    <th><a href="/packages/?{% buildsortqs "arch" %}"
                             title="Sort packages by architecture">Arch</a></th>
-                    <th><a href="/packages/{% buildsortqs "repo" %}"
+                    <th><a href="/packages/?{% buildsortqs "repo" %}"
                             title="Sort packages by repository">Repo</a></th>
-                    <th><a href="/packages/{% buildsortqs "pkgname" %}"
+                    <th><a href="/packages/?{% buildsortqs "pkgname" %}"
                             title="Sort packages by package name">Name</a></th>
                     <th>Version</th>
                     <th>Description</th>
-                    <th><a href="/packages/{% buildsortqs "-last_update" %}"
+                    <th><a href="/packages/?{% buildsortqs "-last_update" %}"
                             title="Sort packages by last update">Last Updated</a></th>
-                    <th><a href="/packages/{% buildsortqs "-flag_date" %}"
+                    <th><a href="/packages/?{% buildsortqs "-flag_date" %}"
                             title="Sort packages by when marked-out of-date">Flag Date</a></th>
                 </tr>
             </thead>
@@ -118,13 +118,13 @@
 
                 <p class="pkglist-nav">
                     {% if page_obj.has_previous %}
-                    <a class="prev" href="/packages/{{page_obj.previous_page_number}}/{{current_query}}"
+                    <a class="prev" href="/packages/{{page_obj.previous_page_number}}/?{{current_query}}"
                         title="Go to previous page">&lt; Prev</a>
                     {% else %}
                     <span class="prev">&lt; Prev</span>
                     {% endif %}
                     {% if page_obj.has_next %}
-                    <a class="next" href="/packages/{{page_obj.next_page_number}}/{{current_query}}"
+                    <a class="next" href="/packages/{{page_obj.next_page_number}}/?{{current_query}}"
                         title="Go to next page">Next &gt;</a>
                     {% else %}
                     <span class="next">Next &gt;</span>
-- 
cgit v1.2.3-2-g168b


From 5abe0727bfa9a4fab24afcccb66da7d8832bf6b9 Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Sun, 13 Mar 2011 11:41:36 -0500
Subject: Show epoch in package version if != 0

Add a full_version property method to our package object that does the
version formatting, and switch all templates displaying package versions
over to this new method.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/search.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'templates/packages/search.html')

diff --git a/templates/packages/search.html b/templates/packages/search.html
index 5d0de1f4..8ea53b8e 100644
--- a/templates/packages/search.html
+++ b/templates/packages/search.html
@@ -99,9 +99,9 @@
                     <td><a href="{{ pkg.get_absolute_url }}"
                             title="Package details for {{ pkg.pkgname }}">{{ pkg.pkgname }}</a></td>
                     {% if pkg.flag_date %}
-                    <td><span class="flagged">{{ pkg.pkgver }}-{{ pkg.pkgrel }}</span></td>
+                    <td><span class="flagged">{{ pkg.full_version }}</span></td>
                     {% else %}
-                    <td>{{ pkg.pkgver }}-{{ pkg.pkgrel }}</td>
+                    <td>{{ pkg.full_version }}</td>
                     {% endif %}
                     <td class="wrap">{{ pkg.pkgdesc }}</td>
                     <td>{{ pkg.last_update|date }}</td>
-- 
cgit v1.2.3-2-g168b


From a0ef88770f5fe318f38eaa7dc794727a507c797b Mon Sep 17 00:00:00 2001
From: Dan McGee <dan@archlinux.org>
Date: Tue, 15 Mar 2011 09:02:22 -0500
Subject: Ensure package search form correctly handles errors

We were silently eating errors and just showing a normal package list if
the form didn't validate. Rather than do that, make sure we return no
packages at all and display the form errors back to the user in a sane
fashion. Adjust the validation methods on the 'limit' parameter so any
integer is acceptable.

Signed-off-by: Dan McGee <dan@archlinux.org>
---
 templates/packages/search.html | 52 ++++++++++++++++++++++++------------------
 1 file changed, 30 insertions(+), 22 deletions(-)

(limited to 'templates/packages/search.html')

diff --git a/templates/packages/search.html b/templates/packages/search.html
index 8ea53b8e..381ebb01 100644
--- a/templates/packages/search.html
+++ b/templates/packages/search.html
@@ -14,28 +14,36 @@
 
     <h3>Package Search</h3>
 
-	<form id="pkg-search" method="get" action="/packages/">
-		<p><input type="hidden" name="sort" value='{{sort}}' /></p>
-		<fieldset>
-			<legend>Enter search criteria</legend>
-			<div><label for="id_arch" title="Limit results a specific CPU architecture">
-					Arch</label>{{ search_form.arch }}</div>
-			<div><label for="id_repo" title="Limit results to a specific respository">
-					Repository</label>{{ search_form.repo }}</div>
-			<div><label for="id_q" title="Enter keywords as desired">
-					Keywords</label>{{ search_form.q }}</div>
-			<div><label for="id_maintainer" title="Limit results to a specific maintainer">
-					Maintainer</label>{{ search_form.maintainer}}</div>
-			<div><label for="id_last_update" title="Limit results to a date after the date entered">
-					Last Updated After</label>{{ search_form.last_update }}</div>
-			<div><label for="id_flagged" title="Limit results based on out-of-date status">
-					Flagged</label>{{ search_form.flagged }}</div>
-			<div><label for="id_limit" title="Select the number of results to display per page">
-					Per Page</label>{{ search_form.limit }}</div>
-			<div ><label>&nbsp;</label><input title="Search for packages using this criteria"
-				type="submit" value="Search" /></div>
-		</fieldset>
-	</form>
+    <form id="pkg-search" method="get" action="/packages/">
+        <p><input type="hidden" name="sort" value='{{sort}}' /></p>
+        {{ search_form.non_field_errors }}
+        <fieldset>
+            <legend>Enter search criteria</legend>
+            <div>{{ search_form.arch.errors }}
+                <label for="id_arch" title="Limit results a specific CPU architecture">
+                    Arch</label>{{ search_form.arch }}</div>
+            <div>{{ search_form.repo.errors }}
+                <label for="id_repo" title="Limit results to a specific respository">
+                    Repository</label>{{ search_form.repo }}</div>
+            <div>{{ search_form.q.errors }}
+                <label for="id_q" title="Enter keywords as desired">
+                    Keywords</label>{{ search_form.q }}</div>
+            <div>{{ search_form.maintainer.errors }}
+                <label for="id_maintainer" title="Limit results to a specific maintainer">
+                    Maintainer</label>{{ search_form.maintainer}}</div>
+            <div>{{ search_form.last_update.errors }}
+                <label for="id_last_update" title="Limit results to a date after the date entered">
+                    Last Updated After</label>{{ search_form.last_update }}</div>
+            <div>{{ search_form.flagged.errors }}
+                <label for="id_flagged" title="Limit results based on out-of-date status">
+                    Flagged</label>{{ search_form.flagged }}</div>
+            <div>{{ search_form.limit.errors }}
+                <label for="id_limit" title="Select the number of results to display per page">
+                    Per Page</label>{{ search_form.limit }}</div>
+            <div ><label>&nbsp;</label><input title="Search for packages using this criteria"
+                type="submit" value="Search" /></div>
+        </fieldset>
+    </form>
 
 </div><!-- #pkglist-search -->
 
-- 
cgit v1.2.3-2-g168b