From 5deece773c4083de6e2769c2ea7976412e40d206 Mon Sep 17 00:00:00 2001 From: Dusty Phillips Date: Fri, 10 Oct 2008 18:16:40 -0400 Subject: replace an ugly query with a nice query --- main/models.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'main/models.py') diff --git a/main/models.py b/main/models.py index a2323c62..9f382cb0 100644 --- a/main/models.py +++ b/main/models.py @@ -189,16 +189,10 @@ class Package(models.Model): """ Returns a list of package objects. """ - reqs = [] - requiredby = PackageDepend.objects.filter(depname=self.pkgname).filter( - Q(pkg__arch=self.arch) | Q(pkg__arch__name__iexact='any')) - for req in requiredby: - reqs.append(req.pkg) - ## sort the resultant list. Django has problems in the orm with - ## trying to shoehorn the sorting into the reverse foreign key - ## reference in the query above. :( - reqs.sort(lambda a,b: cmp(a.pkgname,b.pkgname)) - return reqs + requiredby = Package.objects.filter( + packagedepend__depname=self.pkgname, + arch__name__in=(self.arch.name, 'Any')) + return requiredby.order_by('pkgname') def get_depends(self): """ -- cgit v1.2.3-2-g168b