1 files changed, 26 insertions, 6 deletions

diff --git a/packages/templatetags/package_extras.py b/packages/templatetags/package_extras.py
index 2d51fd40..960fbb4d 100644
--- a/packages/templatetags/package_extras.py
+++ b/packages/templatetags/package_extras.py
@@ -9,13 +9,15 @@ from django.utils.html import escape
 
 register = template.Library()
 
+
 def link_encode(url, query):
     # massage the data into all utf-8 encoded strings first, so urlencode
     # doesn't barf at the data we pass it
-    query = dict((k, unicode(v).encode('utf-8')) for k, v in query.items())
+    query = {k: unicode(v).encode('utf-8') for k, v in query.items()}
     data = urlencode(query).replace('&', '&')
     return "%s?%s" % (url, data)
 
+
 @register.filter
 def url_unquote(original_url):
     try:
@@ -27,6 +29,7 @@ def url_unquote(original_url):
     except UnicodeError:
         return original_url
 
+
 class BuildQueryStringNode(template.Node):
     def __init__(self, sortfield):
         self.sortfield = sortfield
@@ -34,7 +37,13 @@ class BuildQueryStringNode(template.Node):
 
     def render(self, context):
         qs = parse_qs(context['current_query'])
-        if qs.has_key('sort') and self.sortfield in qs['sort']:
+        # This is really dirty. The crazy round trips we do on our query string
+        # mean we get things like u'\xe2\x98\x83' in our views, when we should
+        # have simply u'\u2603' or a byte string of the UTF-8 value. Force the
+        # keys and list of values to be byte strings only.
+        qs = {k.encode('latin-1'): [v.encode('latin-1') for v in vals]
+                for k, vals in qs.items()}
+        if 'sort' in qs and self.sortfield in qs['sort']:
             if self.sortfield.startswith('-'):
                 qs['sort'] = [self.sortfield[1:]]
             else:
@@ -43,27 +52,35 @@ class BuildQueryStringNode(template.Node):
             qs['sort'] = [self.sortfield]
         return urlencode(qs, True).replace('&', '&')
 
+
 @register.tag(name='buildsortqs')
 def do_buildsortqs(parser, token):
     try:
         tagname, sortfield = token.split_contents()
     except ValueError:
         raise template.TemplateSyntaxError(
-                "%r tag requires a single argument" % tagname)
+                "%r tag requires a single argument" % token)
     if not (sortfield[0] == sortfield[-1] and sortfield[0] in ('"', "'")):
         raise template.TemplateSyntaxError(
-                "%r tag's argument should be in quotes" % tagname)
+                "%r tag's argument should be in quotes" % token)
     return BuildQueryStringNode(sortfield[1:-1])
 
+
 @register.simple_tag
-def pkg_details_link(pkg):
+def pkg_details_link(pkg, link_title=None):
+    if not pkg:
+        return link_title or ''
+    if link_title is None:
+        link_title = pkg.pkgname
     link = '<a href="%s" title="View package details for %s">%s</a>'
-    return link % (pkg.get_absolute_url(), pkg.pkgname, pkg.pkgname)
+    return link % (pkg.get_absolute_url(), pkg.pkgname, link_title)
+
 
 @register.simple_tag
 def multi_pkg_details(pkgs):
     return ', '.join([pkg_details_link(pkg) for pkg in pkgs])
 
+
 @register.simple_tag
 def maintainer_link(user):
     if user:
@@ -76,6 +93,7 @@ def maintainer_link(user):
         )
     return ''
 
+
 @register.simple_tag
 def get_download_link(package):
     parts = {
@@ -109,6 +127,7 @@ def get_wiki_link(package):
     }
     return link_encode(url, data)
 
+
 @register.simple_tag
 def svn_arch(package):
     repo = package.repo.name.lower()
@@ -128,6 +147,7 @@ def bugs_list(package):
     }
     return link_encode(url, data)
 
+
 @register.simple_tag
 def bug_report(package):
     url = "https://labs.parabola.nu/projects/issue-tracker/issues/new"