From b20b7b03053f94499085a4570a241428b5676ce2 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Mon, 4 Nov 2013 11:23:01 -0500 Subject: normalize on "[[" instead of "[" --- src/abslibre-tools/libreaddiff | 6 +++--- src/abslibre-tools/librerelease | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/libreaddiff b/src/abslibre-tools/libreaddiff index 9f5ae27..3855279 100755 --- a/src/abslibre-tools/libreaddiff +++ b/src/abslibre-tools/libreaddiff @@ -74,14 +74,14 @@ except StopIteration: load_PKGBUILD "$f/PKGBUILD" || continue is_here=false for arc in ${arch[@]} ; do - if [ "$arc" = "any" -o "$arc" = "$CARCH" ] ; then + if [[ "$arc" == "any" ]] || [[ "$arc" == "$CARCH" ]] ; then is_here=true break fi done - if [ "$is_here" = "true" ] ; then + if [[ "$is_here" == "true" ]] ; then for name in ${pkgname[@]} ; do - if [ -z "$epoch" ] ; then + if [[ -z "$epoch" ]] ; then echo $name-$pkgver-$pkgrel else echo $name-$epoch:$pkgver-$pkgrel diff --git a/src/abslibre-tools/librerelease b/src/abslibre-tools/librerelease index adfb935..d133571 100755 --- a/src/abslibre-tools/librerelease +++ b/src/abslibre-tools/librerelease @@ -80,12 +80,12 @@ create_signature() { } sign_packages() { - if [ -z "${GPG_AGENT_INFO}" ]; then + if [[ -z "${GPG_AGENT_INFO}" ]]; then warning "It's better to use gpg-agent to sign packages in batches" fi for package in $(find "${WORKDIR}/staging/" -type f -iname '*.pkg.tar.?z'); do - if [ -f "${package}.sig" ]; then + if [[ -f "${package}.sig" ]]; then msg2 "Package signature found, verifying..." # Verify that the signature is correct, else remove for re-signing @@ -95,7 +95,7 @@ sign_packages() { fi fi - if ! [ -f "${package}.sig" ]; then + if ! [[ -f "${package}.sig" ]]; then create_signature "$package" || return 2 fi done -- cgit v1.2.3-2-g168b From e362e5b23aa9f7322df5995d4b5e51dfea17956f Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Mon, 4 Nov 2013 11:23:33 -0500 Subject: touch up quoting on arrays --- src/abslibre-tools/libreaddiff | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/libreaddiff b/src/abslibre-tools/libreaddiff index 3855279..ebd749d 100755 --- a/src/abslibre-tools/libreaddiff +++ b/src/abslibre-tools/libreaddiff @@ -80,7 +80,7 @@ except StopIteration: fi done if [[ "$is_here" == "true" ]] ; then - for name in ${pkgname[@]} ; do + for name in "${pkgname[@]}" ; do if [[ -z "$epoch" ]] ; then echo $name-$pkgver-$pkgrel else -- cgit v1.2.3-2-g168b From c230cf6bea67623b3741720255a2acc0075a7965 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Mon, 4 Nov 2013 11:24:25 -0500 Subject: librerelease: mention `gpg-agent --daemon` instead of just `gpg-agent` --- src/abslibre-tools/librerelease | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/librerelease b/src/abslibre-tools/librerelease index d133571..70ff416 100755 --- a/src/abslibre-tools/librerelease +++ b/src/abslibre-tools/librerelease @@ -81,7 +81,7 @@ create_signature() { sign_packages() { if [[ -z "${GPG_AGENT_INFO}" ]]; then - warning "It's better to use gpg-agent to sign packages in batches" + warning "It's better to have \`%s\` running to sign packages in batches" 'gpg-agent --daemon' fi for package in $(find "${WORKDIR}/staging/" -type f -iname '*.pkg.tar.?z'); do -- cgit v1.2.3-2-g168b From 66924443eaf0d4342531323d00add4e14498b76f Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Mon, 4 Nov 2013 11:25:14 -0500 Subject: librerelease: don't redirect output of gpg --detach-sign This should fix fauno's issue with pinentry-curses, or at least fail more verbosely. --- src/abslibre-tools/librerelease | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/librerelease b/src/abslibre-tools/librerelease index 70ff416..b77b6ec 100755 --- a/src/abslibre-tools/librerelease +++ b/src/abslibre-tools/librerelease @@ -68,7 +68,7 @@ create_signature() { SIGNWITHKEY="-u ${GPGKEY}" fi # The signature will be generated directly in ascii-friendly format - gpg --detach-sign --use-agent ${SIGNWITHKEY} "$filename" &>/dev/null || ret=$? + gpg --detach-sign --use-agent ${SIGNWITHKEY} "$filename" || ret=$? if (( ! ret )); then -- cgit v1.2.3-2-g168b From b195c3f87ab2910f76bec71fec659752aa7f6c5a Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Mon, 4 Nov 2013 12:51:14 -0500 Subject: createworkdir: clean up output --- src/abslibre-tools/createworkdir | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/createworkdir b/src/abslibre-tools/createworkdir index 8e88375..4421ae2 100755 --- a/src/abslibre-tools/createworkdir +++ b/src/abslibre-tools/createworkdir @@ -42,10 +42,11 @@ if ! "${cmd[@]}"; then plain "Try running this command:" echo printf '%q ' "${cmd[@]}" + echo exit 1 fi msg "Finished, your packaging directory tree looks like this now:" -ls --color=always "${WORKDIR}"/*/* +ls --color=always "${WORKDIR}"/* trap -- EXIT -- cgit v1.2.3-2-g168b From 91c74601d0e6839e88074a8d2ce3fcfd347b35e5 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Fri, 3 Jan 2014 02:07:30 -0500 Subject: Phase out DIFFTOOL for DIFFPROG (issue #438) https://labs.parabola.nu/issues/438 --- src/abslibre-tools/diff-unfree | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/abslibre-tools') diff --git a/src/abslibre-tools/diff-unfree b/src/abslibre-tools/diff-unfree index b3e2327..1ef0649 100755 --- a/src/abslibre-tools/diff-unfree +++ b/src/abslibre-tools/diff-unfree @@ -23,7 +23,7 @@ . libremessages . $(librelib conf.sh) load_files libretools -check_vars libretools DIFFTOOL || exit 1 +check_vars libretools DIFFPROG || exit 1 usage() { print "Usage: %s [community|packages] [unfree-package] [repo]" "${0##*/}" @@ -80,7 +80,7 @@ main() { for _file in ${unfree_dir}/*; do msg2 "%s" "$(basename "${_file}")" - ${DIFFTOOL} "$PWD/$(basename "${_file}")" "${_file}" + ${DIFFPROG} "$PWD/$(basename "${_file}")" "${_file}" done } -- cgit v1.2.3-2-g168b