Age | Commit message (Collapse) | Author |
|
# Conflicts:
# config
# cron-jobs/makepkg.conf
# cron-jobs/update-web-db
# db-functions
# db-move
# db-remove
# db-update
# test/lib/common.inc
# test/test.d/create-filelists.sh
# test/test.d/db-update.sh
# testing2x
|
|
This does correct handling of
- executing a program by symlink
- any weird characters in the full path
- I'm sure there's another case I thought about when I originally did
this.
|
|
`grep -q` may exit as soon as it finds a match; this is a good optimization
for when the input is a file. However, if the input is the output of
another program, then that other program will receive SIGPIPE, and further
writes will fail. When this happens, it might (bsdtar does) print a
message about a "write error" to stderr. Which is going to confuse and
alarm the user.
I'll add that this is not purely hypothetical--it has happened to me while
running the test suite.
|
|
|
|
# Conflicts:
# test/lib/common.inc
# test/test.d/create-filelists.sh
# test/test.d/db-move.sh
# test/test.d/db-remove.sh
# test/test.d/db-repo-add.sh
# test/test.d/db-repo-remove.sh
# test/test.d/db-update.sh
# test/test.d/ftpdir-cleanup.sh
# test/test.d/sourceballs.sh
|
|
|
|
Other than pure quoting, this involved:
- swapping */@ for array access in a few places
- fiddling with printf in a pipeline
- replacing `$(echo ${array[@]})` with `${array[*]}`
- replacing `echo $(...)` with `...`
When searching for these things, I used the command:
grep -Prn --exclude-dir=.git '(?<!["=]|\[\[ |\[\[ -[zn] )\$(?!{?#|\(|\? )'
and ignored a bunch of false positives.
|
|
- properly set SRCPOOL
- have SVNREPO point to the checkout, not the server repo
- in case TMPDIR has a symlink in it, use `readlink -e` on both sides of
inspecting symlinks.
- use `grep {pattern} &>/dev/null` instead of `grep -q {pattern}`. Because
`grep -q` is able to bail early, a program being piped in to it may spit
out a message about a write error to stderr.
|
|
|
|
|
|
|
|
* A SVNUSER can be configured in the config file
* This user needs to be able to call svn without a password
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* tests can be run seperatly
* runTest will run all tests that have the x bit set
|