From 20ff0cd40fd228f56251634a7429439244c24eac Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Tue, 24 Apr 2012 20:59:24 -0500 Subject: util/testdb: don't return crazy error values With some contrived examples, you could easily make testdb return a very high error count, which could easily overflow the 8-bit unsigned integer limit. Instead, simply return 1 or 0 based on whether errors were found. Signed-off-by: Dan McGee --- src/util/testdb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/util') diff --git a/src/util/testdb.c b/src/util/testdb.c index f3a7b659..2017b60f 100644 --- a/src/util/testdb.c +++ b/src/util/testdb.c @@ -253,7 +253,7 @@ static void usage(void) int main(int argc, char *argv[]) { - int ret = 0; + int errors = 0; alpm_errno_t err; const char *dbpath = DBPATH; int a = 1; @@ -285,13 +285,13 @@ int main(int argc, char *argv[]) alpm_option_set_logcb(handle, output_cb); if(!dbnames) { - ret = check_localdb(); + errors = check_localdb(); } else { - ret = check_syncdbs(dbnames); + errors = check_syncdbs(dbnames); alpm_list_free(dbnames); } - cleanup(ret); + cleanup(errors > 0); } /* vim: set ts=2 sw=2 noet: */ -- cgit v1.2.3-2-g168b