From 7986ec349f520de712b78338699903e8edf9e94d Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:31:23 -0700 Subject: .golangci.yml: Fix syntax --- .golangci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index fb78da2..a4373c0 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,4 +1,4 @@ -# Copyright (C) 2022 Luke Shumaker +# Copyright (C) 2022-2023 Luke Shumaker # # SPDX-License-Identifier: GPL-2.0-or-later @@ -12,5 +12,5 @@ linters-settings: simplify: true issues: exclude-rules: - path: borrowed_example_test.go - linters: [errcheck] + - path: borrowed_example_test.go + linters: [errcheck] -- cgit v1.2.3-2-g168b From 5f6408eef2499b1ed35e215c581647d78dca1557 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 22:43:42 -0700 Subject: .golangci.yml: Don't hide issues from me --- .golangci.yml | 2 ++ 1 file changed, 2 insertions(+) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index a4373c0..d51fec0 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -14,3 +14,5 @@ issues: exclude-rules: - path: borrowed_example_test.go linters: [errcheck] + max-issues-per-linter: 0 + max-same-issues: 0 -- cgit v1.2.3-2-g168b From c14af2a4eb80811e8fb25502b4a07ad2f33804c2 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 22:45:39 -0700 Subject: .golangci.yml: Turn on formatting linters 'gci' and 'gofumpt', fix All formatting changes are made by ./tools/bin/golangci-lint run --fix ./... --- .golangci.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index d51fec0..d35fd4e 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -6,13 +6,22 @@ linters: disable: - structcheck # doesn't support Go 1.18 yet enable: + - gci - gofmt + - gofumpt linters-settings: + gci: + sections: + - standard + - default + - prefix(git.lukeshu.com/go/lowmemjson) gofmt: simplify: true issues: exclude-rules: - - path: borrowed_example_test.go - linters: [errcheck] + - path: "borrowed_.*_test\\.go" + linters: + - errcheck + - gofumpt max-issues-per-linter: 0 max-same-issues: 0 -- cgit v1.2.3-2-g168b From deb6d17fefa89f3301bf68b883640d187e40d4ee Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 22:49:57 -0700 Subject: .golangci.yml: Tighten up the configs of existing linters --- .golangci.yml | 1 + 1 file changed, 1 insertion(+) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index d35fd4e..4ac5ccb 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -18,6 +18,7 @@ linters-settings: gofmt: simplify: true issues: + exclude-use-default: false exclude-rules: - path: "borrowed_.*_test\\.go" linters: -- cgit v1.2.3-2-g168b From 7896d7c7fe62955bbe5e9251fce016e2548794e8 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 22:57:27 -0700 Subject: .golangci.yml: Turn on gosec and nolintlint These are linters that I always like to give extra configuration to. --- .golangci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 4ac5ccb..fce8563 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -9,6 +9,8 @@ linters: - gci - gofmt - gofumpt + - gosec + - nolintlint linters-settings: gci: sections: @@ -17,6 +19,12 @@ linters-settings: - prefix(git.lukeshu.com/go/lowmemjson) gofmt: simplify: true + gosec: + excludes: + - G104 # duplicates errcheck + nolintlint: + require-explanation: true + require-specific: true issues: exclude-use-default: false exclude-rules: @@ -24,5 +32,6 @@ issues: linters: - errcheck - gofumpt + - gosec max-issues-per-linter: 0 max-same-issues: 0 -- cgit v1.2.3-2-g168b From 67b6b99dde3d7a887a73df25b4cd885e8bdcf2de Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:05:39 -0700 Subject: .golangci.yml: Turn on all passing linters --- .golangci.yml | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 7 deletions(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index fce8563..9e1a999 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -3,14 +3,71 @@ # SPDX-License-Identifier: GPL-2.0-or-later linters: + enable-all: true disable: - - structcheck # doesn't support Go 1.18 yet - enable: - - gci - - gofmt - - gofumpt - - gosec - - nolintlint + # Deprecated + - deadcode # deprecated, replaced by 'unused' + - exhaustivestruct # deprecated, replaced by 'exhauststruct' + - golint # deprecated, replaced by 'revive' + - ifshort # deprecated + - interfacer # deprecated + - maligned # deprecated, replaced by 'govet fieldalignement' + - nosnakecase # deprecated, replaced by 'revive var-naming' + - scopelint # deprecated, replaced by 'exportloopref' + - structcheck # deprecated, replaced by 'unused' + - varcheck # deprecated, replaced by 'unused' + + # Don't support Go 1.18 generics yet + - rowserrcheck + - sqlclosecheck + - wastedassign + + # Style + - nlreturn + - nonamedreturns # I name returns for godoc purposes. + - tagliatelle + - wsl + - whitespace + + # Complexity; sometimes code is just complex. + - cyclop + - funlen + - gocognit + - gocyclo + - maintidx + - nestif + + # Miscellaneous + - asciicheck # it's fine to include Unicode + - godox # there are a few known TODOs, and that's OK + - goerr113 # forbids fmt.Errorf(%w), which is just silly + + # These are disabled not because I think they're bad, but because + # they currently don't pass, and I haven't really evaluated them + # yet. + - dupl + - dupword + - errorlint + - exhaustive + - exhaustruct + - forcetypeassert + - gochecknoglobals + - gochecknoinits + - gocritic + - godot + - gomnd + - ireturn + - lll + - nakedret + - noctx + - paralleltest + - prealloc + - revive + - stylecheck + - testpackage + - thelper + - varnamelen + - wrapcheck linters-settings: gci: sections: -- cgit v1.2.3-2-g168b From ec8f03e1f557a0e24380ab4763d937a22e9d4a1c Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:09:37 -0700 Subject: .golangci.yml: Turn on 'dupl', fix --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 9e1a999..73a16ca 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -45,7 +45,6 @@ linters: # These are disabled not because I think they're bad, but because # they currently don't pass, and I haven't really evaluated them # yet. - - dupl - dupword - errorlint - exhaustive -- cgit v1.2.3-2-g168b From 676d6be02292900c2ba47f5c1a95b42ab81a7b93 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:21:49 -0700 Subject: .golangci.yml: Turn on 'dupword', fix --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 73a16ca..765176c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -45,7 +45,6 @@ linters: # These are disabled not because I think they're bad, but because # they currently don't pass, and I haven't really evaluated them # yet. - - dupword - errorlint - exhaustive - exhaustruct -- cgit v1.2.3-2-g168b From b0b7c75e9e2ee8c80a82a04562a1a7c7d117ae0e Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:30:37 -0700 Subject: .golangci.yml: Turn on 'gocritic', fix --- .golangci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 765176c..6291572 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -51,7 +51,6 @@ linters: - forcetypeassert - gochecknoglobals - gochecknoinits - - gocritic - godot - gomnd - ireturn @@ -88,5 +87,8 @@ issues: - errcheck - gofumpt - gosec + - path: "borrowed_.*_test\\.go" + linters: [gocritic] + text: "commentFormatting: put a space between `//` and comment text" max-issues-per-linter: 0 max-same-issues: 0 -- cgit v1.2.3-2-g168b From 690b0cbb2a220ef4179a0f9f34725328fb8c73f8 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:36:55 -0700 Subject: .golangci.yml: Turn on 'godot', fix --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 6291572..cc094f1 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -51,7 +51,6 @@ linters: - forcetypeassert - gochecknoglobals - gochecknoinits - - godot - gomnd - ireturn - lll @@ -85,6 +84,7 @@ issues: - path: "borrowed_.*_test\\.go" linters: - errcheck + - godot - gofumpt - gosec - path: "borrowed_.*_test\\.go" -- cgit v1.2.3-2-g168b From 0616a12019eb3220d437b02a30483720477f14a0 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:44:53 -0700 Subject: .golangci.yml: Turn on 'nakedret', fix --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index cc094f1..cadb81b 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -54,7 +54,6 @@ linters: - gomnd - ireturn - lll - - nakedret - noctx - paralleltest - prealloc -- cgit v1.2.3-2-g168b From 659b2cd182132b0827484855689e3d21e8d9ce9f Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 26 Jan 2023 23:46:25 -0700 Subject: .golangci.yml: Turn on 'noctx', fix --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index cadb81b..0e81d1f 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -54,7 +54,6 @@ linters: - gomnd - ireturn - lll - - noctx - paralleltest - prealloc - revive @@ -86,6 +85,7 @@ issues: - godot - gofumpt - gosec + - noctx - path: "borrowed_.*_test\\.go" linters: [gocritic] text: "commentFormatting: put a space between `//` and comment text" -- cgit v1.2.3-2-g168b From bdfb423cbaff683269c7448afe6d93d224c5a482 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Fri, 27 Jan 2023 00:02:29 -0700 Subject: .golangci.yml: Turn on 'paralleltest', fix --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 0e81d1f..f9e1160 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -54,7 +54,6 @@ linters: - gomnd - ireturn - lll - - paralleltest - prealloc - revive - stylecheck -- cgit v1.2.3-2-g168b From a74b77265f6249385c38ba801822561872418fdf Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Fri, 27 Jan 2023 00:16:03 -0700 Subject: .golangci.yml: Turn on 'prealloc', fix --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index f9e1160..1076d1a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -54,7 +54,6 @@ linters: - gomnd - ireturn - lll - - prealloc - revive - stylecheck - testpackage -- cgit v1.2.3-2-g168b From 2824310168b9dbe24c2d47cfb71d4283b1733642 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Fri, 27 Jan 2023 00:17:49 -0700 Subject: .golangci.yml: Turn on 'stylecheck', fix --- .golangci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to '.golangci.yml') diff --git a/.golangci.yml b/.golangci.yml index 1076d1a..866c5a4 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -55,7 +55,6 @@ linters: - ireturn - lll - revive - - stylecheck - testpackage - thelper - varnamelen @@ -84,8 +83,12 @@ issues: - gofumpt - gosec - noctx + - stylecheck - path: "borrowed_.*_test\\.go" linters: [gocritic] text: "commentFormatting: put a space between `//` and comment text" + - path: "internal/" + linters: [stylecheck] + text: "ST1000" # package doc comment max-issues-per-linter: 0 max-same-issues: 0 -- cgit v1.2.3-2-g168b