diff options
| author | Luke Shumaker <lukeshu@datawire.io> | 2022-08-16 21:24:39 -0600 |
|---|---|---|
| committer | Luke Shumaker <lukeshu@datawire.io> | 2022-08-17 00:13:00 -0600 |
| commit | 0e6d82b97165e9cdd294aaeac02bbbf26263877a (patch) | |
| tree | ec0ba5b156363a3d2754d4164d0124ff5013898c /compat | |
| parent | e57bee02e02b7e3697d6c3cb8b75923a92100427 (diff) | |
borrowed_decode_test.go: Do better checking of errors [ci-skip]
Diffstat (limited to 'compat')
| -rw-r--r-- | compat/json/borrowed_decode_test.go | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/compat/json/borrowed_decode_test.go b/compat/json/borrowed_decode_test.go index ccee264..2c89d5d 100644 --- a/compat/json/borrowed_decode_test.go +++ b/compat/json/borrowed_decode_test.go @@ -1092,13 +1092,19 @@ func TestUnmarshal(t *testing.T) { for i, tt := range unmarshalTests { var scan scanner in := []byte(tt.in) - if err := checkValid(in, &scan); err != nil { - if !equalError(err, tt.err) { - t.Errorf("#%d: checkValid: %#v", i, err) - continue - } + var expSyntaxError error // MODIFIED: added + if _, ok := tt.err.(*SyntaxError); ok { // MODIFIED: added + expSyntaxError = tt.err // MODIFIED: added + } // MODIFIED: added + if err := checkValid(in, &scan); !equalError(err, expSyntaxError) { // MODIFIED: don't ignore cases where it returned nil but should have returned an error + t.Errorf("#%d: checkValid:\n got: %#v\nwant: %#v", i, err, expSyntaxError) // MODIFIED: show what the expected error was + continue } if tt.ptr == nil { + var val any // MODIFIED: added + if err := Unmarshal([]byte(tt.in), &val); !equalError(err, expSyntaxError) { // MODIFIED: added + t.Errorf("#%d: Unmarshal:\n got: %#v\nwant: %#v", i, err, expSyntaxError) // MODIFIED: added + } // MODIFIED: added continue } |