From c007a61ad7e885f7f3dadd05bae555e577ce27c9 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 29 Jan 2015 01:37:13 -0500 Subject: pick: be careful with arguments being flags to 'printf', use stderr --- .local/bin/pick | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.local') diff --git a/.local/bin/pick b/.local/bin/pick index 6dc905f..7458041 100755 --- a/.local/bin/pick +++ b/.local/bin/pick @@ -20,7 +20,7 @@ if [[ $1 = -s ]]; then # Scan to find a running instance for prog in "$@"; do if [[ -n "$(pgrep "${prog%% *}")" ]]; then - printf '%s\n' "$prog" + printf -- '%s\n' "$prog" exit 0 fi done @@ -29,10 +29,10 @@ fi # Scan to find one that is installed for prog in "$@"; do if [[ -x "$(which "${prog%% *}" 2>/dev/null)" ]]; then - printf '%s\n' "$prog" + printf -- '%s\n' "$prog" exit 0 fi done -printf '%s\n' "$cmd: no suitable program found" +printf -- '%s\n' "$cmd: no suitable program found" >&2 exit 1 -- cgit v1.2.3-2-g168b From 1e77007556e623a63478a18790098c510b9cbbd9 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 29 Jan 2015 01:37:40 -0500 Subject: .local/bin/x-*: exec, not eval. I'm smert --- .local/bin/x-pdf | 2 +- .local/bin/x-terminal-emulator | 2 +- .local/bin/x-www-browser | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to '.local') diff --git a/.local/bin/x-pdf b/.local/bin/x-pdf index cfaa258..8f9ef60 100755 --- a/.local/bin/x-pdf +++ b/.local/bin/x-pdf @@ -1,3 +1,3 @@ #!/bin/sh -eval $(pick atril zathura mupdf okular evince xpdf 'emacsclient -c') "$@" +exec $(pick atril zathura mupdf okular evince xpdf 'emacsclient -c') "$@" diff --git a/.local/bin/x-terminal-emulator b/.local/bin/x-terminal-emulator index 075dda5..2e158cf 100755 --- a/.local/bin/x-terminal-emulator +++ b/.local/bin/x-terminal-emulator @@ -1,3 +1,3 @@ #!/bin/sh -eval $(pick 'emacsterm -c' 'urxvt' 'xterm' 'gnome-terminal') "$@" +exec $(pick 'emacsterm -c' 'urxvt' 'xterm' 'gnome-terminal') "$@" diff --git a/.local/bin/x-www-browser b/.local/bin/x-www-browser index 945dcfc..b0b05e0 100755 --- a/.local/bin/x-www-browser +++ b/.local/bin/x-www-browser @@ -1,3 +1,3 @@ #!/bin/sh -eval $(pick -s iceweasel icecat firefox conkeror) "$@" +exec $(pick -s iceweasel icecat firefox conkeror) "$@" -- cgit v1.2.3-2-g168b