From 28549f676e040c96bfae575535dea7e0ecdf0f41 Mon Sep 17 00:00:00 2001
From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Sat, 11 Feb 2023 22:15:41 -0700
Subject: Change how constants are declared to play nice with godoc

Switch to

   NAME Type = val

instead of

   NAME = Type(val)
---
 lib/btrfs/btrfssum/csum.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib/btrfs/btrfssum')

diff --git a/lib/btrfs/btrfssum/csum.go b/lib/btrfs/btrfssum/csum.go
index f436e2c..bce43f9 100644
--- a/lib/btrfs/btrfssum/csum.go
+++ b/lib/btrfs/btrfssum/csum.go
@@ -52,7 +52,7 @@ func (csum CSum) Format(f fmt.State, verb rune) {
 type CSumType uint16
 
 const (
-	TYPE_CRC32 = CSumType(iota)
+	TYPE_CRC32 CSumType = iota
 	TYPE_XXHASH
 	TYPE_SHA256
 	TYPE_BLAKE2
-- 
cgit v1.2.3-2-g168b


From acbbfafa07922b458506b91a58f3a082da453fd1 Mon Sep 17 00:00:00 2001
From: Luke Shumaker <lukeshu@lukeshu.com>
Date: Sat, 11 Feb 2023 22:33:44 -0700
Subject: Try to avoid unnecessary allocations in enum-types' String methods

---
 lib/btrfs/btrfssum/csum.go | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)

(limited to 'lib/btrfs/btrfssum')

diff --git a/lib/btrfs/btrfssum/csum.go b/lib/btrfs/btrfssum/csum.go
index bce43f9..157371e 100644
--- a/lib/btrfs/btrfssum/csum.go
+++ b/lib/btrfs/btrfssum/csum.go
@@ -58,29 +58,30 @@ const (
 	TYPE_BLAKE2
 )
 
+var csumTypeNames = []string{
+	"crc32c",
+	"xxhash64",
+	"sha256",
+	"blake2",
+}
+
+var csumTypeSizes = []int{
+	4,
+	8,
+	32,
+	32,
+}
+
 func (typ CSumType) String() string {
-	names := map[CSumType]string{
-		TYPE_CRC32:  "crc32c",
-		TYPE_XXHASH: "xxhash64",
-		TYPE_SHA256: "sha256",
-		TYPE_BLAKE2: "blake2",
-	}
-	if name, ok := names[typ]; ok {
-		return name
+	if int(typ) < len(csumTypeNames) {
+		return csumTypeNames[typ]
 	}
 	return fmt.Sprintf("%d", typ)
 }
 
 func (typ CSumType) Size() int {
-	//nolint:gomnd // This is where we define the magic numbers.
-	sizes := map[CSumType]int{
-		TYPE_CRC32:  4,
-		TYPE_XXHASH: 8,
-		TYPE_SHA256: 32,
-		TYPE_BLAKE2: 32,
-	}
-	if size, ok := sizes[typ]; ok {
-		return size
+	if int(typ) < len(csumTypeSizes) {
+		return csumTypeSizes[typ]
 	}
 	return len(CSum{})
 }
-- 
cgit v1.2.3-2-g168b