From c65d6effc26c3d97a6193f65c5b7698c830d9ff0 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Fri, 6 Jan 2023 00:52:43 -0700 Subject: btrfssum: Don't emit JSON strings that are too long Split it, and wrap it in an array. --- lib/btrfs/btrfssum/shortsum_test.go | 66 +++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 lib/btrfs/btrfssum/shortsum_test.go (limited to 'lib/btrfs/btrfssum/shortsum_test.go') diff --git a/lib/btrfs/btrfssum/shortsum_test.go b/lib/btrfs/btrfssum/shortsum_test.go new file mode 100644 index 0000000..aa7849a --- /dev/null +++ b/lib/btrfs/btrfssum/shortsum_test.go @@ -0,0 +1,66 @@ +// Copyright (C) 2023 Luke Shumaker +// +// SPDX-License-Identifier: GPL-2.0-or-later + +package btrfssum_test + +import ( + "bytes" + "testing" + + "git.lukeshu.com/go/lowmemjson" + "github.com/stretchr/testify/assert" + + "git.lukeshu.com/btrfs-progs-ng/lib/btrfs/btrfssum" +) + +func TestShortSumEncodeJSON(t *testing.T) { + t.Parallel() + type TestCase struct { + InputSum btrfssum.ShortSum + OutputJSON string + } + testcases := map[string]TestCase{ + "short": { + InputSum: "xyz", + OutputJSON: `"78797a"`, + }, + "long": { + InputSum: "0123456789abcdefghijklmnopqrstuvwxyz;:.,ABCDEFG", + OutputJSON: `["303132333435363738396162636465666768696a6b6c6d6e6f707172737475767778797a3b3a2e2c","41424344454647"]`, + }, + "medium": { // exactly the maximum string length + InputSum: "0123456789abcdefghijklmnopqrstuvwxyz;:.,", + OutputJSON: `"303132333435363738396162636465666768696a6b6c6d6e6f707172737475767778797a3b3a2e2c"`, + }, + } + for tcName, tc := range testcases { + tc := tc + t.Run(tcName, func(t *testing.T) { + t.Parallel() + + var jsonBuf bytes.Buffer + assert.NoError(t, lowmemjson.NewEncoder(&jsonBuf).Encode(tc.InputSum)) + assert.Equal(t, tc.OutputJSON, jsonBuf.String()) + + var rtSum btrfssum.ShortSum + assert.NoError(t, lowmemjson.NewDecoder(&jsonBuf).DecodeThenEOF(&rtSum)) + assert.Equal(t, tc.InputSum, rtSum) + }) + } +} + +func FuzzShortSumJSONFuzz(f *testing.F) { + f.Fuzz(func(t *testing.T, _inSum []byte) { + t.Logf("in = %q", _inSum) + inSum := btrfssum.ShortSum(_inSum) + + var jsonBuf bytes.Buffer + assert.NoError(t, lowmemjson.NewEncoder(&jsonBuf).Encode(inSum)) + t.Logf("json = %q", jsonBuf.Bytes()) + + var outSum btrfssum.ShortSum + assert.NoError(t, lowmemjson.NewDecoder(&jsonBuf).DecodeThenEOF(&outSum)) + assert.Equal(t, inSum, outSum) + }) +} -- cgit v1.2.3-2-g168b