Clean-up made possible by btrfsutil.RebuiltForrest implementing btrfs.ReadableFS

 - rebuildtrees: Use .ForrestLookup instead of .RebuiltTree where possible

 - btrfsutil: noopRebuiltForrestCallbacks: Use only the generic
   btrfstree.Forrest API

 - btrfsutil: RebuiltForrest, RebuiltTree: Avoid unnecessarily
   reaching into forrest.inner

 - btrfsutil: RebuiltTree: Drop the .ReadItem() method; it duplicates
   .TreeLookup without benefit.

1 files changed, 0 insertions, 10 deletions

diff --git a/lib/btrfsutil/rebuilt_tree.go b/lib/btrfsutil/rebuilt_tree.go
index 9ab0356..0844511 100644
--- a/lib/btrfsutil/rebuilt_tree.go
+++ b/lib/btrfsutil/rebuilt_tree.go
@@ -478,16 +478,6 @@ func (tree *RebuiltTree) RebuiltCOWDistance(parentID btrfsprim.ObjID) (dist int,
 	}
 }
 
-// ReadItem reads an item from a tree.
-func (tree *RebuiltTree) ReadItem(ctx context.Context, key btrfsprim.Key) btrfsitem.Item {
-	ptr, ok := tree.RebuiltAcquireItems(ctx).Load(key)
-	tree.RebuiltReleaseItems()
-	if !ok {
-		panic(fmt.Errorf("should not happen: btrfsutil.RebuiltTree.ReadItem called for not-included key: %v", key))
-	}
-	return tree.forrest.readItem(ctx, ptr).Body
-}
-
 // RebuiltLeafToRoots returns the list of potential roots (to pass to
 // .RebuiltAddRoot) that include a given leaf-node.
 func (tree *RebuiltTree) RebuiltLeafToRoots(ctx context.Context, leaf btrfsvol.LogicalAddr) containers.Set[btrfsvol.LogicalAddr] {